Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] / [Feature request]: Working __site_width__ to customize maximum page width for better readability #22

Closed
hubdot opened this issue May 14, 2021 · 3 comments
Assignees
Labels
Category: Feature The issue describes a feature request Priority: Low Resolution: Completed Issue has been fixed and tested

Comments

@hubdot
Copy link

hubdot commented May 14, 2021

Hey nomad,

thanks again for the great work on the template. This one could be a bug or feature request:
In the Template Style Settings a site_width can be set (default 73%) but currently doesn't seem to have an effect.
https://i.imgur.com/vtoAcOe.png

I was expecting this to limit the total site width, as on bigger screens text readability suffers a lot if too wide.
Thus I attempted multiple settings (e.g. 66%, 33%, 1000px, 30rem) but saw no changes no matter the input value: https://i.imgur.com/USKn2vr.png

A draft of what I thought it'd look like is this: https://i.imgur.com/YoEs9tS.png

@hubdot hubdot changed the title BUG / Feature Request: Working __site_width__ to customize maximum page width for better readability [Bug] / [Feature request]: Working __site_width__ to customize maximum page width for better readability May 14, 2021
@nomadjimbob
Copy link
Owner

nomadjimbob commented May 17, 2021

These style settings do not appear to be from the Mikio template so I am not sure where they have come from. The template also has language data for its placeholders so there should not be any placeholders that Mikio supports starting, or ending with "__".

Mikio always uses 100% view width. I can add an option for a max-width, which is what Bootstrap does, centring the site content container on the site. (ie if the site content has a max width of 800 pixels, and the window is 1000 pixels wide, there will be 100 pixel whitespace each site of the site content.

@hubdot
Copy link
Author

hubdot commented May 17, 2021

Hey nomad, :)

thanks for your support. That said you may be absolutely right about your assumption - this is backed up by the following observation, the behavior however is reproducable.

  1. This theme was applied to a standard DokuWikiStick on a windows machine.
  2. When going to the Template Styling Options (.../doku.php?id=home&do=admin&page=styling), at the very bottom it shows the following options by default: https://i.imgur.com/4xxSGAZ.png
  3. However, if you click on [Revert Styles Back To Template's Default] it deletes those options, the result looking like this: https://i.imgur.com/eTZmwZa.png
  4. I have now reset to the templates defaults as a base and as you suggested it now doesn't have the option to width-limit anymore.

That said I'd love your suggestion of adding the option for a max-width based on e.g. rem or px. 👍
I'd be perfectly happy with the centered site as longer text just get's really hard to read at a certain breakpoint, especially on ultra wide screens.
You may want to consider giving it your own personal styling flavor though. E.g. a 100% footer or headerbar could be a design element you want to keep. The herobar should likely resize with the max-width of the content though.
As for width-related readability I believe only the main body is important.

Best regards :)

@nomadjimbob nomadjimbob self-assigned this May 31, 2021
@nomadjimbob nomadjimbob added Category: Feature The issue describes a feature request Priority: Low labels May 31, 2021
@nomadjimbob
Copy link
Owner

nomadjimbob commented May 31, 2021

The next release will add/support the site width setting under the Template Style Settings admin panel. An example of it working is below. Note that I have set the width to smaller than usual to highlight the it on a wide viewport

The next release should be available in a day or 2 once I do a little more testing

Screen Shot 2021-05-31 at 4 08 24 pm

@nomadjimbob nomadjimbob added the Resolution: Completed Issue has been fixed and tested label May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Feature The issue describes a feature request Priority: Low Resolution: Completed Issue has been fixed and tested
Projects
None yet
Development

No branches or pull requests

2 participants