Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags in dark theme are invisible by default #59

Closed
WetenSchaap opened this issue Dec 10, 2023 · 6 comments
Closed

Tags in dark theme are invisible by default #59

WetenSchaap opened this issue Dec 10, 2023 · 6 comments

Comments

@WetenSchaap
Copy link

When using tags (from the Tag Plugin), tags show up nicely in the light theme. In the dark theme however, the background is the same colour as the text.

Light theme:
image

Dark theme:
image

@nomadjimbob
Copy link
Owner

nomadjimbob commented Dec 10, 2023

Check that you have set both the Dark Mode and Normal styling of the tags on the Template Style Settings page in DokuWiki.

By default, they are set to support the hero element on the page
Screenshot 2023-12-11 at 6 24 44 am
Screenshot 2023-12-11 at 6 24 50 am
Screenshot 2023-12-11 at 6 25 28 am
Screenshot 2023-12-11 at 6 25 38 am

@WetenSchaap
Copy link
Author

WetenSchaap commented Dec 11, 2023

They are set to the default value (both in light and dark) but the value gets ignored, not sure what is wrong on my side...

image

If I change the background to a different color, I can read the text.

image

I can try experiment where the color is coming from later.

@nomadjimbob
Copy link
Owner

I tested it and the font color is being respected for myself. Are these tags inside the mikio hero component or elsewhere on the page?
Screenshot 2023-12-11 at 6 31 45 pm

@WetenSchaap
Copy link
Author

I just tried all variations: tags work as expected in the Hero element, but not anywhere else.

Hero:
image

Sidebar:
image

Top of the page (when Hero is disabled):
image

@nomadjimbob
Copy link
Owner

Cool, I got the same thing now.

@nomadjimbob
Copy link
Owner

The latest release (just now - 2023-12-11) should fix the problem. Let me know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants