chore(core): update ngx-stripe module to angular 9 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCHAPLIN
changed the title
|
Wait, I will try to make a full upgrade toward Angular 9 this morning. |
|
Done, waiting reviews. I think this needs to be tested with angular 7 and 8 apps. If someone can, please try to run your app with this module |
FCHAPLIN
changed the title
nosovk
approved these changes
May 7, 2020
paullryan
reviewed
May 11, 2020
| "tslib": "^1.10.0", | ||
| "tslint": "~5.20.0", | ||
| "typescript": "~3.5.3", | ||
| "typescript": "~3.7.5", |
There was a problem hiding this comment.
Angular 9 is not yet compatible with typescript 3.7.5 please use ng update in the future when trying to make changes like this.
| @@ -38,26 +38,26 @@ | |||
| "doctoc": "doctoc README.md --maxlevel 3" | |||
| }, | |||
| "peerDependencies": { | |||
| "@angular/common": "~8.2.9", | |||
| "@angular/common": "~9.0.1", | |||
| "@angular/core": "~8.2.9" | |||
There was a problem hiding this comment.
@angular/core should also be bumped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updated the moduleWithProviders type. Works fine here.
Updating the application is more tricky. We may have to stop using ng-packagr, because it mess with its typescript version.