-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement handleCardSetup() #9
Implement handleCardSetup() #9
Conversation
What is the status on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, many thanks jpcoenen for what you brought. Excuse-me for my stupid question, but I see the implementation is located in a sub project (projects/ngx-stripe/), how can I install it using npm? The "npm install @nomadreservations/projects/ngx-stripe --save" command only installs the root project so I don't have access to handleCardSetup code. Thanks for the help! |
Great question from legrando! |
I understand now that the package was not released since a while. Do you plan to release a new version soon ? As the new european regulation regarding SCA will be in force next month? Many thanks |
|
I am working on the full 3d secure portion of this to release, however it's not ready yet. As @jpcoenen says you can build it from master now for your local, I'll be releasing in the next couple weeks. |
Many thanks guys, I stay tuned then! If I will test my local build and let you know if I have any intersting feedback to share with you. |
Hi, So far, the package I built locally containing the handleCardSetup() works fine. Would it be possible to get an intermediary release (even beta...) with this commit? This would be very useful and so kind! Thanks for your reply. |
Adds the
handleCardSetup()
function that's needed when you want to save a payment method without directly charging with the latest version of the Stripe API.Need the function myself, but also closes #8.