Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(application) Add Fade-to-Black Effect, Update Build Scripts #26

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Sayad-Uddin-Tahsin
Copy link
Contributor

@Sayad-Uddin-Tahsin Sayad-Uddin-Tahsin commented Apr 2, 2024

  • Added a fade-to-black effect for a smoother visual transition within the application.
  • Updated Windows build scripts to include the --add-data flag in the pyinstaller command, ensuring correct inclusion of assets directory and icon file path.
  • Added --clean flag to ensure a clean build process on Windows platform.
  • Updated BlinkEyeApp class with a fade_to_black method for seamless window fading.
  • Modified show_timer_popup method to utilize the new fade_to_black method instead of direct window manipulation.
  • Modified application files to a separate directory /application/* and necessary icon and image files to a /application/Assets/*

Additionally, Address Fedora Package:

  • Corrected license file path in BlinkEye_Fedora.spec.
  • Adjusted build_fedora.sh script for Fedora package with specific options like icon addition, data inclusion, hidden import, and clean build.

P.S.: @fluentmoheshwar please review the Fedora related modifications!

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blink-eye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 6:11pm

Copy link
Contributor

@fluentmoheshwar fluentmoheshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sayad-Uddin-Tahsin
Copy link
Contributor Author

LGTM!

Roger that!

@nomandhoni-cs
Copy link
Owner

Kindly resolve these merge conflicts,
image

Also one more thing I want to, inform to both of you ( @Sayad-Uddin-Tahsin , @fluentmoheshwar ), I've created a develop branch, Please make your PR to the develop branch next time. That when our all testing will be done, then we will merge in to master branch

@fluentmoheshwar
Copy link
Contributor

@Sayad-Uddin-Tahsin please let me know before solving the merge conflicts. I think it's caused by my latest PR

@fluentmoheshwar
Copy link
Contributor

Kindly resolve these merge conflicts,
image

Also one more thing I want to, inform to both of you ( @Sayad-Uddin-Tahsin , @fluentmoheshwar ), I've created a develop branch, Please make your PR to the develop branch next time. That when our all testing will be done, then we will merge in to master branch

Thanks for informing us.

@Sayad-Uddin-Tahsin
Copy link
Contributor Author

@nomandhoni-cs @fluentmoheshwar Reverted all the changes on

BlinkEye_Fedora.spec
build_fedora.sh

But I really don't know why it's still showing Conflict?

@Sayad-Uddin-Tahsin
Copy link
Contributor Author

@Sayad-Uddin-Tahsin please let me know before solving the merge conflicts. I think it's caused by my latest PR

I've tried by reverting all the changes, seems still doesn't work!

@nomandhoni-cs
Copy link
Owner

nomandhoni-cs commented Apr 2, 2024

Can you make a the PR to the develop branch. Then We will try to fix the issues, instead of force merging the conflict in the master.

@Sayad-Uddin-Tahsin
Copy link
Contributor Author

@nomandhoni-cs Can you review it real quick? just synced with base repository and recommitted the changes solved the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants