-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(application) Add Fade-to-Black Effect, Update Build Scripts #26
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Roger that! |
Kindly resolve these merge conflicts, Also one more thing I want to, inform to both of you ( @Sayad-Uddin-Tahsin , @fluentmoheshwar ), I've created a develop branch, Please make your PR to the develop branch next time. That when our all testing will be done, then we will merge in to master branch |
@Sayad-Uddin-Tahsin please let me know before solving the merge conflicts. I think it's caused by my latest PR |
Thanks for informing us. |
@nomandhoni-cs @fluentmoheshwar Reverted all the changes on
But I really don't know why it's still showing Conflict? |
I've tried by reverting all the changes, seems still doesn't work! |
Can you make a the PR to the |
d0f2aa1
to
4816204
Compare
@nomandhoni-cs Can you review it real quick? just synced with base repository and recommitted the changes solved the issue! |
fade-to-black
effect for a smoother visual transition within the application.--add-data
flag in thepyinstaller
command, ensuring correct inclusion of assets directory and icon file path.--clean
flag to ensure a clean build process on Windows platform.BlinkEyeApp
class with afade_to_black
method for seamless window fading.show_timer_popup
method to utilize the newfade_to_black
method instead of direct window manipulation./application/*
and necessary icon and image files to a/application/Assets/*
Additionally, Address Fedora Package:
BlinkEye_Fedora.spec
.build_fedora.sh
script for Fedora package with specific options like icon addition, data inclusion, hidden import, and clean build.P.S.: @fluentmoheshwar please review the
Fedora
related modifications!