Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires blueprint? #88

Closed
adiun opened this issue Oct 30, 2018 · 2 comments · Fixed by #92
Closed

Requires blueprint? #88

adiun opened this issue Oct 30, 2018 · 2 comments · Fixed by #92

Comments

@adiun
Copy link
Contributor

adiun commented Oct 30, 2018

I just pulled 2.0.1 and I see that MosaicZeroState and MosaicWindow now has a dependency on @blueprintjs/core and @blueprintjs/icons. After I upgrade the version I get an error during build saying that it can't resolve @blueprintjs/icons and @blueprintjs/core. Is that intended? I saw PR #10 which removes the dependency...

Bug report

  • Package version(s): 2.0.1
  • Browser and OS versions: Windows, Chrome

Steps to reproduce

  1. I had version 1.1.1 of react-mosaic-component without any blueprintjs deps.
  2. Changed 1.1.1 to 2.0.1 in package.json
  3. npm install
  4. npm run build which runs webpack

Actual behavior

ERROR in ./node_modules/react-mosaic-component/lib/MosaicWindow.js
Module not found: Error: Can't resolve '@blueprintjs/core' in '...\node_modules\react-mosaic-component\lib'
 @ ./node_modules/react-mosaic-component/lib/MosaicWindow.js 46:13-41
 @ ./node_modules/react-mosaic-component/lib/index.js

ERROR in ./node_modules/react-mosaic-component/lib/MosaicZeroState.js
Module not found: Error: Can't resolve '@blueprintjs/core' in '...\node_modules\react-mosaic-component\lib'
 @ ./node_modules/react-mosaic-component/lib/MosaicZeroState.js 35:13-41
 @ ./node_modules/react-mosaic-component/lib/index.js

Expected behavior

No build error, no need to install @blueprintjs/core and @blueprintjs/icons.

@nomcopter
Copy link
Owner

Definitely not intended. Will look into.

@kmannislands
Copy link

Was also surprised by a similar Module not found: Error: Can't resolve '@blueprintjs/core' from webpack on fresh installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants