Removed extraneous and shortened text in accessibility name and description fields #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iption fields. This will make the speech output less verbose for screen reader users
cebtenzzre
reviewed
Oct 19, 2023
gpt4all-chat/qml/ChatDrawer.qml
Outdated
| Accessible.name: qsTr("Edit the chat name") | ||
| Accessible.description: qsTr("Provides a button to edit the chat name") | ||
| Accessible.name: qsTr("Edit chat name") | ||
| Accessible.description: qsTr("") |
There was a problem hiding this comment.
In the case of empty descriptions like this, I think we could remove the whole line that sets it.
There was a problem hiding this comment.
Either way is fine with me. I just left them empty in case someone decides to add those descriptions in the future (I doubt it though).
Let me know and I'd be happy to remove them.
cebtenzzre
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the speech output less verbose for screen reader users.