Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lightmode and darkmode themes with UI revamp. #1876

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Jan 26, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

Comment on lines +17 to +20
width: 1920
height: 1080
minimumWidth: 1280
minimumHeight: 720
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we are changing this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application when it comes up is far smaller by default than other applications of its kind. Further, with the new home page we need more space for the large font and so on.

@cebtenzzre
Copy link
Member

On my Mac, the links at the top neither light up nor change the cursor when you hover them, so it's not as obvious that they are clickable as it should be.

@manyoso
Copy link
Collaborator Author

manyoso commented Jan 26, 2024

On my Mac, the links at the top neither light up nor change the cursor when you hover them, so it's not as obvious that they are clickable as it should be.

Same behavior on linux. This is intended. I can change this, but not all links behave with something happening on hover.

@cebtenzzre
Copy link
Member

And the smaller labels to the left of the controls are harder to read IMO:
Screenshot 2024-01-26 at 11 49 07 AM

Compared to the previous version:
Screenshot 2024-01-26 at 11 52 39 AM

Btw, you forgot to sign off on your commits, so the DCO check is failing. You should git commit --amend -s and force-push.

@cebtenzzre
Copy link
Member

More small text on macOS:
Screenshot 2024-01-26 at 12 06 14 PM

Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso merged commit 3556f63 into main Jan 29, 2024
6 of 10 checks passed
@Phil209
Copy link

Phil209 commented Feb 4, 2024

The new UI is hogging a 1080p monitor.

I often have a browser windows open docked on the right (or another app) and GPT4ALL docked on the left to look things up. But the new UI forces a very large minimal size so it doesn't docked to half of a 1920 wide screen, which is something I've never encountered before after using 100s of apps on a large 1920x1080 display.

Forcing a very large minimal window size is also making it harder to multi-task in other ways, such as watching a show while GPT4ALL is generating responses. Plus it messed up all my scripts I made to automate functionality. I would resize it to the same place so I could automate pasting, execution, copying... It's easy enough to re-write them to the new minimum size, but like I said, the new minimum size is far too large to allow multitasking on a 1920x1080 screen so I have to revert to the previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants