chatllm: fix undefined behavior in resetContext #2041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat::reset -> ChatLLM::resetContext is called when we change models. This will happen even if no model has been previously loaded.
In that case, m_llModelType is unset (contains a garbage value). regenerateResponse will attempt to read m_llModelType, causing undefined behavior (found by UBSAN) - but it seems like resetResponse was intended here anyway.