Fix issue #2087 where cloned models were lost and listed in download … #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dialog erroneously. Signed-off-by: Adam Treat <treat.adam@gmail.com>
|
Could you explain how listing clones in DownloadableModels caused them to be lost after a restart? |
So it turns out that the batch update fixed the issue with the clone disappearing. I can't replicate it with the batch update patch and this one applied, but I can replicate without the batch update patch. I think there was a case where the order of the update mattered, but with the batch update I moved the 'installed' role to be first in the list when creating a clone and I think that is what solved the issue. Before we weren't recording the 'isClone' in the settings file. |
cebtenzzre
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.