Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2077 part 2. Only sort when actually necessary. #2094

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Mar 8, 2024

No description provided.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso requested a review from cebtenzzre March 8, 2024 16:04
@manyoso
Copy link
Collaborator Author

manyoso commented Mar 8, 2024

This also seems to mitigate substantially the problem with the responsiveness of the model download dialog when download is taking place on windows which before this was unbearably slow.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso merged commit 8ee68d1 into main Mar 8, 2024
6 of 10 checks passed
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants