Fix to set proper app icon on MacOS. #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Verduijn <robinverduijn.github@gmail.com>
robinverduijn
force-pushed
the
feat/macos-app-icon
branch
from
f057e95
to
b106775
Compare
manyoso
approved these changes
Apr 1, 2024
cebtenzzre
added a commit
that referenced
this pull request
May 8, 2024
This has been redundant since PR #2180. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
manyoso
pushed a commit
that referenced
this pull request
May 9, 2024
* chat: fix window icon on Windows Signed-off-by: Jared Van Bortel <jared@nomic.ai> * chat: remove redundant copy of macOS app icon This has been redundant since PR #2180. Signed-off-by: Jared Van Bortel <jared@nomic.ai> --------- Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This sets the app icon properly so that when built on MacOS, the app icon shows as intended. While the favicon.icns file appears to be specified in some places, it's necessary to include it in the Resources folder and the appropriate executable manifest for it to actually be used on MacOS.
Issue ticket number and link
Checklist before requesting a review
Demo
Steps to Reproduce
Build the app and check the build output folder (e.g. build-gpt4all-chat-Desktop_arm_darwin_generic_mach_o_64bit-Release/bin) to view the app icon. It should be the GPT4All icon from favicon.icns. After applying the fix, it may be necessary to manually remove the build output dir and run Clean on the project to handle caching around the app icon.
Notes