Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixpanel: improved GPU device statistics (plus GPU sort order fix) #2297

Merged
merged 4 commits into from
May 1, 2024

Conversation

cebtenzzre
Copy link
Member

@cebtenzzre cebtenzzre commented May 1, 2024

Added properties to model_load event:

  • default_device: what GPU would have been chosen if "Auto" were selected (unset if none available)
  • default_device_mem: how much VRAM said GPU has in GiB, rounded down to the nearest 100MiB (e.g. 3.2)
  • requested_device_mem: how much VRAM the device the user has requested has in GiB

Other changes:

  • Pick the GPU with the most VRAM by default, not the least (GPT4All has been wanting to use my GTX 970 instead of my P40 until now)
  • Do not search for a device named "Metal" on macOS devices (there won't be any devices anyway)
  • If somehow the requested GPU does not exist, use the default GPU instead of the CPU (shouldn't happen in practice but it makes the code simpler)

Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
@cebtenzzre cebtenzzre requested a review from manyoso May 1, 2024 18:56
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
@cebtenzzre cebtenzzre merged commit adaecb7 into main May 1, 2024
6 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants