chat: fix blank device in UI after model switch and improve Mixpanel reporting #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function has never been used and is equivalent to whether the last call to initializeGPUDevice() returned true. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
This fixes the issue where reusing a model for a new chat would cause the device name and fallback reason to be lost - both in the UI, and on Mixpanel. Also, separate the device name from the backend (now at the "deviceBackend" prop) on Mixpanel. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
|
The merge conflicts will be resolved after #2408 is merged. |
iimez
added a commit
to iimez/gpt4all
that referenced
this pull request
Jun 4, 2024
Signed-off-by: limez <limez@protonmail.com>
manyoso
approved these changes
Jun 26, 2024
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
QVariant() is `undefined` in QML, while QString() is `null`. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
When we do CPU fallback and request CUDA with ngl=0, it still uses the GPU for matrix multipliciation. It shouldn't clear the GPU device on failure, as it is still relevant when we fall back. We also shouldn't allow loadModel with an unset device. This fixes a case where gpuDeviceName() would return "", because usingGPUDevice() reported true while we had no known device name. Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional Changes
actualDevice="GTX 970 (CUDA)"andactualDevice="Tesla P40 (Vulkan)". Now they are reported asactualDevice="GTX 970", device_backend="CUDA"andactualDevice="Tesla P40", device_backend="Vulkan".default_deviceon Mixpanel still shows plain device names in v2.8.0.default_device_backendis added to supplement this (should always be "Vulkan" in official releases).Other Changes