Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Allow for multiline prompt and visual processing feedback #2434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kiggundu
Copy link

@kiggundu kiggundu commented Jun 12, 2024

Describe your changes

This PR address the following usability issues with the CLI

  • It is now possible to paste text into prompt containing carriage returns. Before this reulted in
    individual lines being submitted making it imposible to include code examples in the prompt.
  • An Ascii spinning whheel now provides visual feedback that processing is happening. Before it
    was not possible to tell whether the script was simply frozen for responses that take longer to produce.
  • A robot icon to mark the responses. Before it was difficult to single out responses in long running conversations

Issue ticket number and link

Checklist before requesting a review

  • [:heavy_check_mark: ] I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • [:heavy_check_mark: ] I have added thorough documentation for my code.
  • [ ✔️ ] I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

demo.mp4

Steps to Reproduce

Notes

@ThiloteE
Copy link
Collaborator

If it's UI related, please provide screenshots.

@kiggundu
Copy link
Author

If it's UI related, please provide screenshots.

If it's UI related, please provide screenshots.

sure. have attached an mp4 of the modified cli and cleaned up the implementation further.

Signed-off-by: Abraham Kiggundu <abraham@thekiggys.com>
@cosmic-snow
Copy link
Collaborator

Sorry, I'm the wrong person to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants