file won't get rolled if the process restarted daily #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomiddlename
added a commit
that referenced
this pull request
Apr 21, 2014
file won't get rolled if the process restarted daily
|
Thanks for this. |
|
Pushed to npm in v0.6.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dateFile appender works fine for server processes, I found the problem when I use it in a daily cron job.
this.lastTimeWeWroteSomething is inited with current time, so if we restart a process on a daily base, it will always return the same date string,
=> The log file will never get rolled and it will keep growing.
The fix is done by checking existing log file, if there is one then get lastTimeWeWroteSomething from the file stat.