Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Log4js for use in Hapi #290

Closed
wants to merge 4 commits into from
Closed

Conversation

thebergamo
Copy link

The tests only can running if hapi added on the package.json.

npm install --save-dev hapi

The tests need improve, but its works.
#289

@nomiddlename
Copy link
Collaborator

Thanks for this - my only issue is that it looks like the version of hapi in package.json doesn't support node 0.8 (which log4js does), so the build fails. Any suggestions? Is there an older version of hapi that will still work?

@thebergamo
Copy link
Author

Well, I do some fix when I implemented in my projects. Because I don't understand very much about the Vowsjs I can't write better tests an any help is very encouraging and welcomed.
About the issue, on tomorrow morning(GMT +3) I'll see this build more close and trying do it more compatible, but in version 8 of hapi some interfaces are broken, I will see how I can improve it =D

@thebergamo
Copy link
Author

Sorry about that, @nomiddlename support node v0.8 is a big Job, because I need use an oldest version of Hapi. I think maybe if you can update the CI node version for v0.10 and v0.12. (On version 0.12) the tests are broken.

What you mean?

@nomiddlename
Copy link
Collaborator

log4js no longer supports versions of node.js below 4, so this might be worth revisiting now.

@thebergamo thebergamo closed this Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants