Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid boxing #646

Merged
merged 1 commit into from
Apr 10, 2017
Merged

avoid boxing #646

merged 1 commit into from
Apr 10, 2017

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Apr 5, 2017

@codecov-io
Copy link

codecov-io commented Apr 5, 2017

Codecov Report

Merging #646 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage      50%   49.97%   -0.03%     
==========================================
  Files         173      173              
  Lines       11167    11167              
  Branches     1548     1566      +18     
==========================================
- Hits         5584     5581       -3     
- Misses       5583     5586       +3
Impacted Files Coverage Δ
...cala/spire/math/extras/interval/IntervalTrie.scala 0% <0%> (ø) ⬆️
...d/src/main/scala_2.10/spire/util/OptVersions.scala 0% <0%> (-66.67%) ⬇️
...e/shared/src/main/scala/spire/math/Algebraic.scala 67.35% <0%> (-1.65%) ⬇️
...ore/shared/src/main/scala/spire/math/Natural.scala 58.46% <0%> (-0.93%) ⬇️
extras/src/main/scala/spire/math/FixedPoint.scala 36.06% <0%> (-0.55%) ⬇️
core/shared/src/main/scala/spire/math/Real.scala 67.19% <0%> (-0.32%) ⬇️
...re/shared/src/main/scala/spire/math/Rational.scala 96.02% <0%> (-0.25%) ⬇️
core/js/src/main/scala/spire/Platform.scala
...d/src/main/scala_2.13/spire/util/OptVersions.scala 66.66% <0%> (ø)
...red/src/main/scala/spire/math/poly/PolyDense.scala 97.36% <0%> (+1.31%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72bd4d...d7848f5. Read the comment docs.

@tixxit
Copy link
Contributor

tixxit commented Apr 5, 2017

LGTM

@denisrosset denisrosset merged commit 8be6bba into typelevel:master Apr 10, 2017
@xuwei-k xuwei-k deleted the isNaN-boxing branch June 20, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants