#11 mesh setEnabled true when load completed

ref: https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/loaders/src/glTF/2.0/glTFLoader.ts#L562
noname0310 · Aug 8, 2023 · 88a0596 · 88a0596
1 parent 90451bf
commit 88a0596
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.24.0
+
+- Shows the mesh when all texture loads and shaders are compiled
+
 ## 0.23.0
 
 - fix object freezing in place to set physics body linear damping to 6.0

diff --git a/src/Loader/Optimized/bpmxLoader.ts b/src/Loader/Optimized/bpmxLoader.ts
@@ -265,6 +265,7 @@ export class BpmxLoader implements ISceneLoaderPluginAsync, ILogger {
         const mesh = new (state.useSdef ? SdefMesh : Mesh)(bpmxObject.header.modelName, scene);
         mesh._parentContainer = assetContainer;
         scene._blockEntityCollection = false;
+        mesh.setEnabled(false);
 
         const vertexData = new VertexData();
         vertexData.positions = bpmxObject.geometry.positions;
@@ -668,6 +669,8 @@ export class BpmxLoader implements ISceneLoaderPluginAsync, ILogger {
 
         applyTextureLoading = true;
         await textureLoadPromise;
+
+        mesh.setEnabled(true);
 
         if (assetContainer !== null) {
             assetContainer.meshes.push(mesh);

diff --git a/src/Loader/pmxLoader.ts b/src/Loader/pmxLoader.ts
@@ -275,6 +275,7 @@ export class PmxLoader implements ISceneLoaderPluginAsync, ILogger {
         const mesh = new (state.useSdef ? SdefMesh : Mesh)(pmxObject.header.modelName, scene);
         mesh._parentContainer = assetContainer;
         scene._blockEntityCollection = false;
+        mesh.setEnabled(false);
 
         const vertexData = new VertexData();
         const boneSdefC = state.useSdef ? new Float32Array(pmxObject.vertices.length * 3) : undefined;
@@ -810,6 +811,8 @@ export class PmxLoader implements ISceneLoaderPluginAsync, ILogger {
         applyTextureLoading = true;
         await textureLoadPromise;
 
+        mesh.setEnabled(true);
+
         if (assetContainer !== null) {
             assetContainer.meshes.push(mesh);
             assetContainer.geometries.push(geometry);