Use Babel's js parser #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calls decode(). Follow the same strategy.
|
@jmfederico Thank you for the pull request! Looks fine, I approve. |
|
@jmfederico many thanks for your PR |
|
Version 1.3 now available in pypi: https://pypi.python.org/pypi/babel-vue-extractor |
|
Great! Glad I could contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this extractor does not takes into account the keyword arguments which instructs which functions are to be searched for.
By using the same js parser that babel uses, we can offload most of the work to babel itself, and now it searches for any keyword as function, not only gettext and ngettext.