Fixed detection which App wrote a browser console error

nonblocking · May 7, 2024 · 6a08f49 · 6a08f49
1 parent 9080591
commit 6a08f49
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,8 @@
 
 ## [unreleased]
 
+ * Portal: Fixed detection which App wrote a browser console error 
+   (the portalAppName will now be set properly in the server log)
 
 ## 2.6.0 (April 6, 2024)
 
@@ -42,7 +44,7 @@
    ```
  * HTTP Proxy: Removed [request](https://github.com/request/request) based proxy implementation because the module is deprecated for over 4 years now
  * Upgrade to Express 4.19 + all other libraries upgraded
- * HTTP Portal: Fixed the problem that remote subscriptions can receive the same message multiple times if subscription patterns overlap
+ * Portal: Fixed the problem that remote subscriptions can receive the same message multiple times if subscription patterns overlap
    See [#115](https://github.com/nonblocking/mashroom/issues/115)
 
 ## 2.5.4 (January 28, 2024)

diff --git a/...ages/plugin-packages/mashroom-portal/src/frontend/portal-client/js/BrowserErrorHandler.ts b/...ages/plugin-packages/mashroom-portal/src/frontend/portal-client/js/BrowserErrorHandler.ts
@@ -58,7 +58,7 @@ const getAppNameFromStack = (stack: string): string | undefined => {
     for (let i = 0; i < reverseStackRows.length; i++) {
         const portalAppName = getAppNameFromScript(reverseStackRows[i]);
         if (portalAppName) {
-            break;
+            return portalAppName;
         }
     }
     return undefined;

diff --git a/packages/test/test-server1/log4js.json b/packages/test/test-server1/log4js.json
@@ -7,7 +7,7 @@
             "backups": 3,
             "layout": {
                 "type": "pattern",
-                "pattern": "%d %p %X{sessionID} %X{clientIP} %X{browser} %X{browserVersion} %X{username} %c - %m"
+                "pattern": "%d %p %X{sessionID} %X{clientIP} %X{browser} %X{browserVersion} %X{username} %X{portalAppName} %c - %m"
             }
         },
         "console": {