Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 支持 re.Match 依赖注入 #1950

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Feature: 支持 re.Match 依赖注入 #1950

merged 3 commits into from
Apr 27, 2023

Conversation

yanyongyu
Copy link
Member

related #1453

@yanyongyu yanyongyu added enhancement New feature or request Breaking Breaking change labels Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

🚀 Deployed on https://deploy-preview-1950--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 07:53 Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1950 (ecbe34c) into master (6173836) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
- Coverage   88.63%   88.59%   -0.04%     
==========================================
  Files          45       45              
  Lines        3247     3236      -11     
==========================================
- Hits         2878     2867      -11     
  Misses        369      369              
Flag Coverage Δ
unittests 88.59% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/consts.py 100.00% <ø> (ø)
nonebot/params.py 100.00% <100.00%> (ø)
nonebot/rule.py 97.59% <100.00%> (-0.03%) ⬇️

@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 08:31 Inactive
Copy link
Member

@mnixry mnixry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,但是根据搜索结果,好像现在仍然在依赖RegexMatched返回的str的插件还挺多的,没问题嘛

/cc @A-kirami

Copy link
Member Author

还有依赖regex matched的str的插件?

@A-kirami
Copy link
Contributor

LGTM,但是根据搜索结果,好像现在仍然在依赖RegexMatched返回的str的插件还挺多的,没问题嘛

/cc @A-kirami

搜索结果中,注入了RegexMatched()的共计15个仓库,排除掉nb2自身,仅14个。
而在这14个之中,仅有7个是nb2插件,再排除掉不在目前nb2商店中的,仅余下6个,其中5个插件更是同一作者。
我觉得这种情况来看,依赖RegexMatched的插件实在不能算多。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Breaking change enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants