Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aiohttp 请求时 data 和 file 不能同时存在 #2088

Merged
merged 2 commits into from Jun 11, 2023

Conversation

j1g5awi
Copy link
Member

@j1g5awi j1g5awi commented Jun 10, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2023

🚀 Deployed on https://deploy-preview-2088--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 10, 2023 08:31 Inactive
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #2088 (14d5cb8) into master (572be1e) will increase coverage by 0.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2088      +/-   ##
==========================================
+ Coverage   89.17%   89.54%   +0.36%     
==========================================
  Files          46       46              
  Lines        3179     3289     +110     
==========================================
+ Hits         2835     2945     +110     
  Misses        344      344              
Flag Coverage Δ
unittests 89.54% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nonebot/drivers/aiohttp.py 61.79% <100.00%> (ø)

... and 15 files with indirect coverage changes

@github-actions github-actions bot temporarily deployed to pull request June 10, 2023 08:45 Inactive
@yanyongyu yanyongyu added the bug Something isn't working label Jun 10, 2023
@yanyongyu yanyongyu changed the title Fix:aiohttp 请求时 data 和 file 不能同时存在 Fix: aiohttp 请求时 data 和 file 不能同时存在 Jun 10, 2023
Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要加一下测试?

@github-actions github-actions bot temporarily deployed to pull request June 11, 2023 06:47 Inactive
@yanyongyu yanyongyu merged commit 3242770 into master Jun 11, 2023
22 checks passed
@yanyongyu yanyongyu deleted the fix/aiohttp-requset branch June 24, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

2 participants