Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: 优化 pydantic 兼容函数 model_dump 和 type_validate_json #2579

Merged
merged 6 commits into from
Feb 17, 2024
Merged

Feature: 优化 pydantic 兼容函数 model_dump 和 type_validate_json #2579

merged 6 commits into from
Feb 17, 2024

Conversation

MingxuanGame
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Feb 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e82e281) 94.01% compared to head (a904936) 94.01%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2579   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          48       48           
  Lines        3909     3913    +4     
=======================================
+ Hits         3675     3679    +4     
  Misses        234      234
Flag Coverage Δ
unittests 94.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-2579--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 17, 2024 13:23 Inactive
@yanyongyu yanyongyu added the enhancement New feature or request label Feb 17, 2024
yanyongyu
yanyongyu reviewed Feb 17, 2024
View reviewed changes
Copy link
Member

@yanyongyu yanyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__all__ 没有修改，另外需要加一下测试用例在test compat里，确保兼容性能够正常执行

@github-actions github-actions bot temporarily deployed to pull request February 17, 2024 14:09 Inactive
yanyongyu
yanyongyu reviewed Feb 17, 2024
View reviewed changes
tests/test_compat.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request February 17, 2024 14:46 Inactive
@yanyongyu yanyongyu changed the title Feature: 为 model_dump 增加 exclude_* 参数、添加 type_validate_json 函数 Feature: 优化 pydantic 兼容函数 model_dump 和 type_validate_json Feb 17, 2024
@yanyongyu yanyongyu merged commit a830346 into master Feb 17, 2024
41 of 43 checks passed
@yanyongyu yanyongyu deleted the feature/pydantic-methods branch February 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanyongyu yanyongyu yanyongyu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MingxuanGame @yanyongyu