-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: 添加对 fastapi_reload
在 Windows 平台额外影响的说明
#830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 42 42
Lines 3083 3083
=======================================
Hits 2356 2356
Misses 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
🚀 Deployed on https://deploy-preview-830--nonebot2.netlify.app |
根据 @SK-415 反馈, 似乎beta2锁定的uvicorn版本 |
你说的情况在低版本 但是在 encode/uvicorn#1070 中,为了适配 Python 3.1.0,Windows 下原本用于替换 然后在 encode/uvicorn#1257 中,Windows 系统带了 上述改动在 |
确认,问题确实依然存在,感谢指正。 我没有注意到 Nonebot2 增加了 改正后重新测试,确认使用的是 |
但是我觉得这条提示的信息量有点少,对于没有经验的开发者很难意识到 “事件循环强制绑定到 我的建议是找个地方(比如就这里)总结一下可能产生的问题,并在提示最后加一句类似于:“可能导致部分库无法正常运行(详见……)” 并附上总结的链接。 |
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢PR, 可以稍微改一下上述这些地方的表述
另外请将修改后的文档同步到website/docs/tutorial
, 以便使未来版本的文档也包含该更改
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-beta.2/tutorial/choose-driver.md
Outdated
Show resolved
Hide resolved
…iver.md Co-authored-by: Mix <32300164+mnixry@users.noreply.github.com>
…iver.md Co-authored-by: Mix <32300164+mnixry@users.noreply.github.com>
…iver.md Co-authored-by: Mix <32300164+mnixry@users.noreply.github.com>
…iver.md Co-authored-by: Mix <32300164+mnixry@users.noreply.github.com>
…iver.md Co-authored-by: Mix <32300164+mnixry@users.noreply.github.com>
fastapi_reload
在 win 的额外影响fastapi_reload
在 Windows 平台额外影响的说明
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢PR,将会在稍后合并。
在 python 3.8 之后 , win平台默认使用
ProactorEventLoop
, 而 uvicorn 在启动reload
后会强制绑定默认事件循环为SelectorEventLoop
, 后者在 win 平台的可使用性不如前者 , 也会导致一些使用 asyncio 的包出错(如 playwright)以下是一些相关信息
uvicorn#529
python doc