Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues with default pool and with missing bucket for chunk #6078

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fixing issues with default pool and with missing bucket for chunk #6078

merged 1 commit into from
Jul 6, 2020

Conversation

jackyalbo
Copy link
Contributor

Explain the changes

  1. handling chunks with no buckets in scrubber - avoiding issues with building chunks that don't have a bucket set due to deleting bucket before deleting all the objects
  2. fixing issue when we didn't update account default pool after the first optimal pool was created - due to breaking the loop if no system when start running pool_server

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

@jackyalbo jackyalbo requested a review from nb-ohad July 6, 2020 13:33
nb-ohad
nb-ohad approved these changes Jul 6, 2020
View reviewed changes
src/server/system_services/pool_server.js Outdated Show resolved Hide resolved
@jackyalbo jackyalbo merged commit da255af into noobaa:master Jul 6, 2020
@jackyalbo jackyalbo deleted the jacky_undefined_fix branch June 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@nb-ohad nb-ohad nb-ohad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackyalbo @nimrod-becker @nb-ohad