Fix error reporting when R\W path has errors #6102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
|
I created an image based on 5.5 (dannyzaken/noobaa-core:test-s3-fix). waiting for @MeridianExplorer to run the failing test on it |
|
I tried the |
dannyzaken
changed the title
jeniawhite
approved these changes
Jul 26, 2020
| @@ -3494,7 +3495,12 @@ class NodesMonitor extends EventEmitter { | |||
| 'issues_report', item.node.issues_report, | |||
| 'block_report', block_report); | |||
| // disconnect from the node to force reconnect | |||
| this._disconnect_node(item); | |||
| // only disconnect if enough time passed since last disconnect to avoid amplification of errors in R\W flows | |||
| const DISCONNECT_GRACE_PERIOD = 2 * 60 * 1000; // 2 minutes grace before another disconnect | |||
There was a problem hiding this comment.
Maybe add this to config.js?
There was a problem hiding this comment.
It’s something very specific to this flow. I usually prefer to put it close to the usage in these cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
report_error_on_node_blocksblock_store_clientwere referencing properties of undefined objects. fixed messagesIssues: Fixed #xxx / Gap #xxx
Testing Instructions: