Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to isa-l crytpo 2.22.0 #6215

Merged
merged 1 commit into from Oct 21, 2020
Merged

update to isa-l crytpo 2.22.0 #6215

merged 1 commit into from Oct 21, 2020

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Oct 14, 2020 •
edited

Explain the changes

  1. Updating isa-l crypto to 2.22.0
  2. MD5 (And SHA1 - marked out due to native code sha1 calculation is wrong #6223) unit-test

Issues: Fixed #xxx / Gap #xxx

  1. Fixed BZ#1878714

Testing Instructions:

  1. MD5 unit test

@nimrod-becker nimrod-becker mentioned this pull request Oct 14, 2020
Merged
guymguym
guymguym requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See couple of comments

@jackyalbo
Copy link
Contributor Author

@guymguym please take a look if it's looks ok - added the bases for sha256 and sha512
as well as adding sha1_ni_x2.asm and sha256_ni_x2.asm.

didn't add those: include/memcpy_inline.h, and md5_mb/md5_ref.c
let me know if we need them

@jackyalbo jackyalbo force-pushed the jacky-isa-2.2 branch 2 times, most recently from 8d664d6 to e5690d2 Compare October 15, 2020 06:54
@liranmauda
Copy link
Contributor

/retest ci/centos/unit

guymguym
guymguym reviewed Oct 21, 2020
View reviewed changes
Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the test, but otherwise looks good

@jackyalbo
update to isa-l crytpo 2.22.0
27b97ca 
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@jackyalbo jackyalbo merged commit 4e0ec64 into noobaa:master Oct 21, 2020
@liranmauda liranmauda mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackyalbo @liranmauda @guymguym