-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | Folders extended attributes #7020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-dirs-xattr
branch
3 times, most recently
from
July 27, 2022 07:50
fc5c956
to
c388426
Compare
jackyalbo
reviewed
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly need more explanations. Also let's schedule a meeting in order to push this quicker.
romayalon
force-pushed
the
romy-dirs-xattr
branch
9 times, most recently
from
September 4, 2022 15:10
036735f
to
6172b11
Compare
guymguym
reviewed
Sep 15, 2022
guymguym
reviewed
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
godspeed
romayalon
force-pushed
the
romy-dirs-xattr
branch
3 times, most recently
from
September 29, 2022 15:47
c8081ac
to
3e79557
Compare
2 tasks
waiting for #6973 |
romayalon
force-pushed
the
romy-dirs-xattr
branch
3 times, most recently
from
March 14, 2023 19:48
ce7ab01
to
fae65a3
Compare
romayalon
force-pushed
the
romy-dirs-xattr
branch
from
March 16, 2023 16:53
ad5f9c3
to
ce66868
Compare
jackyalbo
reviewed
Mar 21, 2023
romayalon
force-pushed
the
romy-dirs-xattr
branch
2 times, most recently
from
March 28, 2023 07:48
4b11292
to
2102b2c
Compare
jackyalbo
approved these changes
Apr 25, 2023
romayalon
force-pushed
the
romy-dirs-xattr
branch
3 times, most recently
from
April 27, 2023 07:18
dbea645
to
1a8eb1f
Compare
Signed-off-by: Romy <romy2232@gmail.com>
romayalon
force-pushed
the
romy-dirs-xattr
branch
from
April 27, 2023 08:55
69784de
to
875d34d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Romy romy2232@gmail.com
Explain the changes
FS Napi - added dir_content xattr to the USER_XATTRS vector.
test_namespace_fs - added unit tests
namespace_fs -
b. list objects -
- Skipped processing entry when entry is .folder file.
- Checked existence of XATTR_DIR_CONTENT xattr in the dir's xattr in process_dir and when evaluated to true the entry will be added to the objects list (when no delimiter or in other corner cases)
c. read_object_md - added true to the call of get_version_path in order to get the directory path and not the .folder file when object is a directory content object.
d. upload_object / complete_multipart_upload -
d.1. upload_object -
* Created the .folder file only when content size > 0 when the entry is a directory.
* Created _create_empty_dir_content function for the creation of directory objects of size 0 - this function created
the directory key, sets the xattr on the directory, deleted the old directory if exists, and returns directory info as a
upload_info response.
* On non-empty dir content - added a check to finish_upload() to not set the xattr on the object itself but put it on the
directory instead.
d.2. mpu -
* we always create a .folder file as we assume the size is always > 0
* when object is a dir content object -
- skipped set xattr on .folder.
- replaced old xattr with new xattr and added XATTR_DIR_OBJ xattr to the directory.
- no override case - as we assume size > 0.
e. delete_object / delete_multiple_objects -
- Unlink - skipped when the file is .folder and error code is ENOENT (needed for directory objects of size 0)
- Called clear xattr on directories ( needed for non-empty directory objects )
f. get_object - called stat when the file is .folder and checked if XATTR_DIR_CONTENT xattr exists, if yes, returned {}; (needed for directory objects of size 0)
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: