Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Versioning | find_version_path() optimization #7239

Merged
merged 1 commit into from
Mar 23, 2023
Merged

NSFS | Versioning | find_version_path() optimization #7239

merged 1 commit into from
Mar 23, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Mar 21, 2023 •
edited

Explain the changes

  1. remove extra stat from find_version_path() which appears later in the calling functions

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from vh05 March 21, 2023 12:44
vh05
vh05 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@vh05 vh05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romayalon
find version path optimization
4656c17 
Signed-off-by: Romy <romy2232@gmail.com>
@romayalon romayalon force-pushed the romy-find-version-path-optimization branch from 4ae78f5 to 4656c17 Compare March 23, 2023 09:36
@romayalon romayalon merged commit 02ce6b7 into noobaa:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vh05 vh05 vh05 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @vh05