housekeeping: cleanup logs, tsc errors, global requires #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Margalit <guymguym@gmail.com>
Signed-off-by: Guy Margalit <guymguym@gmail.com>
shirady
reviewed
Mar 22, 2023
| @@ -692,7 +700,13 @@ class NamespaceS3 { | |||
|
|
|||
| /** | |||
| * | |||
| * @param {AWS.S3.HeadObjectOutput | AWS.S3.GetObjectOutput} res | |||
| * @param {Omit<Partial< | |||
There was a problem hiding this comment.
Omit is from typescript? (it is a javascript file I don't understand).
And another question - did you use an automatic tool for all the changes that are JSDoc comments?
There was a problem hiding this comment.
This is a jsdoc with typescript.
https://www.typescriptlang.org/docs/handbook/type-checking-javascript-files.html#supported-jsdoc
There was a problem hiding this comment.
the tool is tsc - npm run ts
shirady
reviewed
Mar 22, 2023
| @@ -307,6 +304,7 @@ class ObjectSDK { | |||
|
|
|||
| _setup_merge_namespace(bucket) { | |||
| let rr = _.cloneDeep(bucket.namespace.read_resources); | |||
| /** @type {nb.Namespace} */ | |||
There was a problem hiding this comment.
This @type is for the wr variable?
If so, why not add the @type line before rr variable statement?
There was a problem hiding this comment.
leaving something for others :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: