Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

housekeeping: error_utils, tsc fixes, tools fixes #7242

Merged
merged 1 commit into from
Mar 22, 2023
Merged

housekeeping: error_utils, tsc fixes, tools fixes #7242

merged 1 commit into from
Mar 22, 2023

Conversation

guymguym
Copy link
Member

Explain the changes

  1. error_utils to unify how we throw errors with a code string (NOTE: it's not the same as rpc_code!)
  2. typescript fixes - add more accurate type info.
  3. s3cat - simplify the --endpoint option, presign fix, tsc fixes.
  4. s3perf - simplify the --endpoint option, listing objects for --get/head/delete options.
  5. fs_speed - add --read option.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. NA

@guymguym
housekeeping: error_utils, tsc fixes, tools fixes
d329040 
Signed-off-by: Guy Margalit <guymguym@gmail.com>
liranmauda
liranmauda approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guymguym guymguym merged commit 26a78c0 into noobaa:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guymguym @liranmauda