Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint stats refactor #7244

Merged
merged 1 commit into from
Mar 26, 2023
Merged

endpoint stats refactor #7244

merged 1 commit into from
Mar 26, 2023

Conversation

guymguym
Copy link
Member

@guymguym guymguym commented Mar 26, 2023

Explain the changes

  1. endpoint_stats_collector - print stats to log, and extract triggering and error handling to utils:
    1. DelayedTrigger util - a robust trigger util so we don't miss updates.
    2. DelayedCollector util - handles errors by merging stats so we don't override updates.
  2. object_sdk - cleanups and refactor common stats calling code (_call_op_and_update_stats)
  3. pass stats instance to namespaces so they don't need rpc_client and it can also be null for tests.
  4. namespace_cache fix calls to update_hub_latency_stats.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. NA

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments,
Beside, LGTM

src/util/delayed_trigger.js Show resolved Hide resolved
src/util/delayed_trigger.js Outdated Show resolved Hide resolved
src/util/delayed_trigger.js Show resolved Hide resolved
src/sdk/object_sdk.js Show resolved Hide resolved
src/sdk/endpoint_stats_collector.js Show resolved Hide resolved
src/sdk/endpoint_stats_collector.js Show resolved Hide resolved
src/sdk/endpoint_stats_collector.js Show resolved Hide resolved
@guymguym guymguym force-pushed the guy-p4 branch 2 times, most recently from bd8ba92 to 994741d Compare March 26, 2023 14:24
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym merged commit bc8663b into noobaa:master Mar 26, 2023
@guymguym guymguym added the Standalone Work items needed to run standalone (without kubernetes) label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Standalone Work items needed to run standalone (without kubernetes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants