Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version from 18.12.1 to 18.14.2 #7248

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Mar 29, 2023

Explain the changes

  • Bump node version from 18.12.1 to 18.14.2
  • Removed the unsafe-perm from npm config

Signed-off-by: liranmauda liran.mauda@gmail.com

@liranmauda
Copy link
Contributor Author

Converted to draft.
By the look of it, in the downstream it bumps npm to v9
Need to use npm v9 and see that we can actually build.

@liranmauda
Copy link
Contributor Author

@b-ranto
we should see that it can pass on downstream, with the lock file changes and without.
can you also review this PR?
(P.S. unsafe params are not set in the downstream).

@nimrod-becker nimrod-becker requested review from a team and baum and removed request for a team April 3, 2023 12:40
@liranmauda liranmauda force-pushed the liran-bump-to-node-18 branch 3 times, most recently from 7ffb789 to d4a8782 Compare June 20, 2023 12:51
- Bump node version from 18.12.1 to 18.14.2
- Removed the unsafe-perm from npm config
- Updated the package-lock.json `lockfileVersion` from 2 to 3

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda marked this pull request as ready for review June 20, 2023 12:53
@liranmauda
Copy link
Contributor Author

Scratch build passed in the downstream using npm v9

@liranmauda liranmauda merged commit 2d145e2 into noobaa:master Jun 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants