Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing azure-storage from the code #7250

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

liranmauda
Copy link
Contributor

Explain the changes

  1. Removing azure-storage from the code

@liranmauda
Copy link
Contributor Author

This PR is a draft as it is still dirty, needs to be rearranged, and needs to be tested.
Pending on azure blob credentials to test.

@liranmauda liranmauda force-pushed the liran-remove-azure-storage branch 3 times, most recently from c33cbf0 to 2c78b8a Compare June 11, 2023 09:20
@liranmauda liranmauda force-pushed the liran-remove-azure-storage branch 2 times, most recently from 4e16902 to 5f20604 Compare July 6, 2023 09:09
@liranmauda liranmauda force-pushed the liran-remove-azure-storage branch 3 times, most recently from 7b5de4c to 0a68904 Compare July 11, 2023 10:23
@liranmauda liranmauda marked this pull request as ready for review July 11, 2023 10:26
@liranmauda liranmauda force-pushed the liran-remove-azure-storage branch 2 times, most recently from 979c1b8 to 554f2a0 Compare July 12, 2023 12:10
- Remove the get_container_client and call it directly.
- Removed azure_storage.CONCURRENCY_NUM
- Renamed new_azure_storage_wrap to azure_storage_wrap

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda merged commit 14bf92b into noobaa:master Jul 12, 2023
6 of 7 checks passed
@liranmauda liranmauda deleted the liran-remove-azure-storage branch July 13, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants