support custom config for backing stores #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. support disabling chunk digest/encryption/compression. 2. support disabling md5/sha256 for etag. 3. support increasing max object part size. 4. support using erasure coding by default. Signed-off-by: Guy Margalit <guymguym@gmail.com>
romayalon
approved these changes
Apr 2, 2023
guymguym
commented
Apr 2, 2023
| const id = updates?._id || entity._id; | ||
| if (id) return 'id-' + id.toHexString(); | ||
|
|
||
| return ''; |
There was a problem hiding this comment.
@romayalon I wonder if I should throw here instead of silently "failing" ... WDYT?
There was a problem hiding this comment.
Is there a situation where we get there? I couldn't find one and I thought that id is the default
There was a problem hiding this comment.
right, we shouldn't get there, this is why I thought it might be better to throw
guymguym
added
the
Standalone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: