Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone backingstore agent #7257

Merged
merged 1 commit into from
Apr 4, 2023
Merged

standalone backingstore agent #7257

merged 1 commit into from
Apr 4, 2023

Conversation

guymguym
Copy link
Member

@guymguym guymguym commented Apr 2, 2023

Explain the changes

  1. add a standalone backingstore program.
  2. specify a port and a path on command line args for each backingstore.
  3. choose the agent ip based on the server address for easy cluster networks.
  4. allow agent request auth when protocol is not only n2n to support direct tcp connect.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. NA

@guymguym guymguym requested a review from a team April 2, 2023 23:26
@guymguym guymguym changed the title standalone backing store agent standalone backingstore agent Apr 2, 2023
src/agent/agent.js Show resolved Hide resolved
src/agent/backingstore.js Outdated Show resolved Hide resolved
src/agent/backingstore.js Show resolved Hide resolved
src/agent/backingstore.js Outdated Show resolved Hide resolved
src/agent/backingstore.js Show resolved Hide resolved
src/agent/backingstore.js Show resolved Hide resolved
src/agent/backingstore.js Show resolved Hide resolved
src/rpc/ice.js Show resolved Hide resolved
@shirady
Copy link
Contributor

shirady commented Apr 3, 2023

@guymguym, I looked at the Ceph tests that are failing - in all the attempts the number is 188 failing tests (consistent).
Do you know why it happens?

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
@guymguym with this changes, can we completely drop the ICE, or do we miss something?

@guymguym
Copy link
Member Author

guymguym commented Apr 3, 2023

I looked at the Ceph tests that are failing - in all the attempts the number is 188 failing tests (consistent). Do you know why it happens?

@shirady yeah it's a problem in my code - I could see it in the agent log there (in the diagnostics tar). just quickly pasting here for tracking -

Apr-3 6:57:10.132 [Agent/22] [ERROR] Agent.noobaa-default-backing-store-noobaa-pod-3dca8ca8-noobaa_storage-71ac1f18:: agent api not allowed for protocol null connection *(l64zixvu) allowed protocol n2n:
Apr-3 6:57:10.132 [Agent/22] [ERROR] CONSOLE:: RPC._on_request: ERROR srv block_store_api.write_block reqid 9@n2n://642a72762237990029df0496(ln1gnnab) connid *(l64zixvu) Error: agent api not allowed for protocol null
    at Agent._authenticate_agent_api (/root/node_modules/noobaa-core/src/agent/agent.js:640:19)
    at Agent.rpc.register_service.middleware (/root/node_modules/noobaa-core/src/agent/agent.js:190:46)
    at RPC._on_request (/root/node_modules/noobaa-core/src/rpc/rpc.js:323:27)
    at /root/node_modules/noobaa-core/src/rpc/rpc.js:734:38
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) 

@guymguym guymguym force-pushed the guy-p5 branch 3 times, most recently from 62ba6c0 to 91c6b51 Compare April 4, 2023 07:52
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym
Copy link
Member Author

guymguym commented Apr 4, 2023

with this changes, can we completely drop the ICE, or do we miss something?

@liranmauda not yet - this does allow us to bypass ice and use a fixed AGENT_RPC_PORT and AGENT_RPC_PROTOCOL=tcp, however I still did not fix the callers to send auth_token and validate it in the agents.

@guymguym guymguym merged commit 861e6f9 into noobaa:master Apr 4, 2023
5 checks passed
@shirady
Copy link
Contributor

shirady commented Apr 4, 2023

@guymguym Did you notice that the build of noobaa tester takes about an hour?
Screenshot 2023-04-04 at 16 25 49

@guymguym
Copy link
Member Author

guymguym commented Apr 4, 2023

Did you notice that the build of noobaa tester takes about an hour?

@shirady I don't think it was related to the PR - I see that after the merge new build was regular so perhaps its an unrelated load - https://github.com/noobaa/noobaa-core/actions/runs/4608283705

@guymguym guymguym added the Standalone Work items needed to run standalone (without kubernetes) label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Standalone Work items needed to run standalone (without kubernetes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants