-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standalone backingstore agent #7257
Conversation
@guymguym, I looked at the Ceph tests that are failing - in all the attempts the number is 188 failing tests (consistent). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
@guymguym with this changes, can we completely drop the ICE, or do we miss something?
@shirady yeah it's a problem in my code - I could see it in the agent log there (in the diagnostics tar). just quickly pasting here for tracking -
|
62ba6c0
to
91c6b51
Compare
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@liranmauda not yet - this does allow us to bypass ice and use a fixed AGENT_RPC_PORT and AGENT_RPC_PROTOCOL=tcp, however I still did not fix the callers to send auth_token and validate it in the agents. |
@guymguym Did you notice that the build of |
@shirady I don't think it was related to the PR - I see that after the merge new build was regular so perhaps its an unrelated load - https://github.com/noobaa/noobaa-core/actions/runs/4608283705 |
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: