Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.NSFS_OPEN_READ_MODE='rd' for O_DIRECT #7260

Merged
merged 1 commit into from
Apr 4, 2023
Merged

config.NSFS_OPEN_READ_MODE='rd' for O_DIRECT #7260

merged 1 commit into from
Apr 4, 2023

Conversation

guymguym
Copy link
Member

@guymguym guymguym commented Apr 4, 2023 •
edited

Explain the changes

  1. optional config to make nsfs reads use O_DIRECT in order to bypass kernel fs cache (pagepool).
  2. Needed for performance tests to disable the cache effects and see direct storage performance.
  3. cc @eshelmarc

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. NA

@guymguym
add config.NSFS_OPEN_READ_MODE for O_DIRECT
df35a20 
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym requested a review from romayalon April 4, 2023 14:58
@guymguym guymguym added this to To Do in NS-FS via automation Apr 4, 2023
@guymguym guymguym added the NS-FS label Apr 4, 2023
NS-FS automation moved this from To Do to In Progress Apr 4, 2023
@guymguym guymguym merged commit 81307b6 into noobaa:master Apr 4, 2023
5 checks passed
NS-FS automation moved this from In Progress to Done Apr 4, 2023
@dannyzaken dannyzaken mentioned this pull request Apr 17, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

Assignees
No one assigned
Labels
NS-FS size/M
Projects
NS-FS
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guymguym @romayalon