-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bucket authentication for server side encryption algorithm #7273
Conversation
3323ade
to
eb9819a
Compare
a1a3ead
to
f51ab06
Compare
f51ab06
to
30a8df3
Compare
30a8df3
to
f8c665b
Compare
2a315bb
to
dc57609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add unit tests to cover these changes in test_s3_bucket_policy. Please add.
9ac1f2b
to
eea5c65
Compare
I have added unit tests. also I have noticed I didn't handle returning the condition values to their original values in get _bucket_policy, so I have added that, and unit test for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think if this is actually required.
@dannyzaken WDYT?
I don't think that we should add bucket authentication for server-side encryption algorithm In a PR just for fixing a ceph test.
As @dannyzaken and I suggested before, this feels too big of a change as it is touching the authentication, and we should do it as a feature and not partially as part of a ceph test.
I think that we should close this PR.
d2f00a9
to
8c61e2c
Compare
8c61e2c
to
6bad43f
Compare
6bad43f
to
9c59dee
Compare
3c21ee2
to
9ba289e
Compare
9ba289e
to
05506b0
Compare
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
05506b0
to
f375893
Compare
Explain the changes
expend bucket policy to enable statements containing conditions for authenticating based on server side encryption algorithm. providing base for farther adding other condition statements. enabling deny, accept bucket policies for stringEquals StringNotEquals and null conditions for server side encryptions
Testing Instructions: