Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Native | Call setgroups syscall instead of lib call #7287

Merged
merged 1 commit into from
May 5, 2023
Merged

NSFS | Native | Call setgroups syscall instead of lib call #7287

merged 1 commit into from
May 5, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Apr 30, 2023 •
edited

Explain the changes

  1. changed setgroups() call to a direct syscall because the libc wrappers will send signals to make these settings apply to ALL threads of the process. (converted to the same mechanism we used for setting uid gid)

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-groups-syscall branch 4 times, most recently from 94f4f90 to 3b4b9f7 Compare May 2, 2023 16:21
@romayalon
call setgroups syscall instead of lib call
c5a44d6 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@guymguym guymguym merged commit dcf4716 into noobaa:master May 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @guymguym