add support for RPM package builds #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh-pro/add/rpm-builds
branch
5 times, most recently
from
7453939
to
1311061
Compare
tangledbytes
force-pushed
the
utkarsh-pro/add/rpm-builds
branch
from
1311061
to
646b1e3
Compare
guymguym
reviewed
May 28, 2023
There was a problem hiding this comment.
@Utkarsh-pro This is a great PR! Let's get it into master.
- Please rebase.
- I wonder - is it possible to use the final
noobaaimage as base instead ofnoobaa-baseimage? - Let's get @liranmauda review if we haven't yet.
|
@Utkarsh-pro I pulled this PR and tried to run |
liranmauda
reviewed
Jun 5, 2023
|
I'm reviving this discussion as we finally have a way forward with our RPM offering. From a dependencies point of view, node binary should be inside the RPM. |
tangledbytes
force-pushed
the
utkarsh-pro/add/rpm-builds
branch
from
646b1e3
to
cff87c3
Compare
tangledbytes
changed the title
|
Tried uploading the built RPMs here for others to try it out and play around with it but GH won't let me upload files > 25M. |
tangledbytes
force-pushed
the
utkarsh-pro/add/rpm-builds
branch
from
cff87c3
to
63fd624
Compare
liranmauda
reviewed
Jul 18, 2023
tangledbytes
force-pushed
the
utkarsh-pro/add/rpm-builds
branch
from
63fd624
to
1ae0240
Compare
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> transient Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add support for multiplatform builds and RPM package builds Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> revert transient changes Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix node version Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> make "jemalloc" a weak dependency Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add support for dynamic changelog Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add support for upgrade script trigger post install Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> remove redundant build copy Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh-pro/add/rpm-builds
branch
from
1ae0240
to
54be5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR:
How to use?
Prerequisites:
docker run --privileged --rm tonistiigi/binfmt --install allBuild:
make rpm. This will create an RPM package and will dump it inside./build/rpm/<name>..nvmrc).boostshared objects to be present on the machine where noobaa is supposed to be installed. This feature can be disabled if not required (due to additional dependency) by runningmake rpm BUILD_S3SELECT=0.make rpm CONTAINER_PLATFORM=linux/amd64ormake rpm CONTAINER_PLATFORM=linux/ppc64le.Post install expectations:
node,npm,npxshould be installed.noobaa-corefiles should be present in/usr/local/noobaa-core.NOTE:
NooBaa uses
jemallocas its allocator optionally.jemallocis not bundled with noobaa-core RPM and needs to be installed manually. Ifepel-releaserepository is available anddnfpackage manager is being used in that case it will try to installjemallocautomatically but can be ignored by passing--setopt=install_weak_deps=Falsetodnf.Testing
Follow the above
BuildandPost install expectationsguide.Previously tested build process on arm64, amd64, ppc64le.
Recent build tested on arm64 and amd64 only.