Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3select parquet fs #7293

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

alphaprinz
Copy link
Contributor

@alphaprinz alphaprinz commented May 4, 2023

Explain the changes

  1. Implement s3select for parquet in nsfs.

Issues: Fixed #xxx / Gap #xxx

  1. No support for other namespaces nor noobaa.
  2. build issues TBD (specifically downstream, but upstream build changes are also not final yet)

Testing Instructions:

  1. Get a parquet file in nsfs. A simple way is with
    -node src/core/nsfs.js /home/aprinzse/work/nsfs/
    -alias s3-user1='AWS_ACCESS_KEY_ID=dc1 AWS_SECRET_ACCESS_KEY=dc2 aws --endpoint https://127.0.0.1:6443 --no-verify-ssl s3'
    -s3-user1 mb s3://
    -s3-user1 cp <parquet_file> s3://

-AWS_ACCESS_KEY_ID=dc1 AWS_SECRET_ACCESS_KEY=dc2 aws --endpoint https://127.0.0.1:6443 --no-verify-ssl s3api select-object-content --bucket --key --expression "select * from stdin;" --expression-type 'SQL' --input-serialization '{"Parquet": {}}' --output-serialization '{"CSV": {}}' "output.csv"

  • Doc added/updated
  • Tests added

@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 9 times, most recently from 76485c6 to b3423cc Compare May 11, 2023 08:50
@alphaprinz alphaprinz marked this pull request as ready for review May 11, 2023 12:34
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 2 times, most recently from 8f4f357 to a0f3c98 Compare May 17, 2023 06:56
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 3 times, most recently from d354969 to 0fcbfa0 Compare May 24, 2023 10:15
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 2 times, most recently from d2065f3 to a436a05 Compare May 28, 2023 06:26
@@ -4,13 +4,16 @@ LABEL maintainer="Liran Mauda (lmauda@redhat.com)"
##############################################################
# Layers:
# Title: Installing pre requirments
# Size: ~ 613 MB
# Size: ~ 1324 MB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG ...
@liranmauda Are we going to survive this bump? (assuming it really bumped in this PR and not before)

@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 2 times, most recently from ef2e4d4 to b707f9c Compare July 3, 2023 08:33
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 5 times, most recently from 9e23833 to b1a4e28 Compare July 10, 2023 11:33
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 2 times, most recently from 9832bce to 8c9378b Compare July 19, 2023 09:10
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 2 times, most recently from cf2908a to c2dd14f Compare August 2, 2023 11:01
@alphaprinz alphaprinz force-pushed the s3select_parquet_fs branch 2 times, most recently from 6120154 to 31c71de Compare August 3, 2023 06:48
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
Author:    Amit Prinz Setter <aprinzse@ibm.com>
Date:      Thu Mar 23 14:40:51 2023 +0200
@alphaprinz alphaprinz merged commit b91c142 into noobaa:master Aug 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants