Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate MD5 per account #7297

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Calculate MD5 per account #7297

merged 2 commits into from
Jun 13, 2023

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented May 11, 2023 •
edited

Explain the changes

  1. Added a flag to calculate MD5 etag per account.
  • Tests added

@achouhan09 achouhan09 marked this pull request as draft May 11, 2023 08:51
@achouhan09 achouhan09 requested review from dannyzaken, a team and tangledbytes and removed request for a team May 11, 2023 08:52
tangledbytes
tangledbytes reviewed May 11, 2023
View reviewed changes
src/util/chunk_fs.js Outdated Show resolved Hide resolved
@dannyzaken dannyzaken mentioned this pull request May 15, 2023
Merged
1 task
@achouhan09 achouhan09 force-pushed the acc-nsfs-etag branch 2 times, most recently from 9123a55 to cf1cbc5 Compare May 19, 2023 09:11
dannyzaken
dannyzaken reviewed May 21, 2023
View reviewed changes
src/sdk/object_sdk.js Outdated Show resolved Hide resolved
dannyzaken
dannyzaken reviewed May 22, 2023
View reviewed changes
src/sdk/object_sdk.js Outdated Show resolved Hide resolved
@achouhan09 achouhan09 force-pushed the acc-nsfs-etag branch 3 times, most recently from 2080548 to 351be04 Compare May 23, 2023 06:21
@achouhan09 achouhan09 marked this pull request as ready for review May 23, 2023 06:22
@achouhan09 achouhan09 force-pushed the acc-nsfs-etag branch 2 times, most recently from d8b7f2a to a6411bb Compare May 25, 2023 08:26
@pull-request-size pull-request-size bot added size/S and removed size/M labels May 25, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 25, 2023
@achouhan09 achouhan09 force-pushed the acc-nsfs-etag branch 2 times, most recently from 26fbd61 to f8552ec Compare June 7, 2023 07:24
@achouhan09 achouhan09 force-pushed the acc-nsfs-etag branch 5 times, most recently from a1b34b2 to 8a238cc Compare June 9, 2023 10:02
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 9, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 12, 2023
Aayush added 2 commits June 13, 2023 10:04
Calculate MD5 per account
44bd5ae 
- Implemented force_md5_etag flag in account
- Added unit test for force_md5_etag in account

Signed-off-by: Aayush <aayush@li-2392f9cc-287a-11b2-a85c-9fcc04b05da6.ibm.com>
Updated tests for md5_etag_calculation flow
355a984 
Signed-off-by: Aayush <aayush@li-2392f9cc-287a-11b2-a85c-9fcc04b05da6.ibm.com>
@achouhan09 achouhan09 merged commit 96641ea into noobaa:master Jun 13, 2023
6 checks passed
@achouhan09 achouhan09 deleted the acc-nsfs-etag branch June 13, 2023 08:27
@achouhan09 achouhan09 mentioned this pull request Mar 21, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@tangledbytes tangledbytes tangledbytes approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achouhan09 @dannyzaken @tangledbytes