Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests | Azurite Blob Emulator adoption for tests #7298

Merged
merged 1 commit into from
May 16, 2023
Merged

Tests | Azurite Blob Emulator adoption for tests #7298

merged 1 commit into from
May 16, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented May 11, 2023 •
edited

Explain the changes

  1. Added deployment and deletion of Azure blob emulator on tests
  2. test_s3_ops.js - Added the relevant connection details in order to connect the blob emulator, and skipped unsupported API tests(StageBlockFromURI).

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. make test / make single test and check that azure flow was tested
  • Doc added/updated
  • Tests added

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 11, 2023
nadavMiz
nadavMiz approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@nadavMiz nadavMiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon force-pushed the romy-azure-mock branch 5 times, most recently from 337e3fa to 19b131f Compare May 16, 2023 12:23
@romayalon
Azurite Blob Emulator adoption for tests
de0b91e 
Signed-off-by: Romy <romy2232@gmail.com>
@romayalon romayalon merged commit 59426e2 into noobaa:master May 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadavMiz nadavMiz nadavMiz approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @nadavMiz