Removing DOCKER_BUILDKIT env variable from the Makefile #7300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-remove-buildkit
branch
from
e200460
to
af98e3a
Compare
|
@liranmauda does the CI docker engine has buildkit enabled by default as well? If not, should we add |
|
It seems that The CI does not have it. |
|
Yeah, it doesn't seem like we use any docker buildx specific features. |
tangledbytes
approved these changes
May 18, 2023
Removing DOCKER_BUILDKIT env variable from the Makefile Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-remove-buildkit
branch
from
af98e3a
to
c7c5a33
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Removing DOCKER_BUILDKIT env variable from the Makefile