New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit dummy access key and secret key from agent logs #7301

Merged

nadavMiz merged 1 commit into noobaa:master from nadavMiz:access-key-fix

May 21, 2023

Contributor

nadavMiz commented May 21, 2023

Explain the changes

omit dummy access key and secret key from agent logs

Issues: Fixed #xxx / Gap #xxx

https://bugzilla.redhat.com/show_bug.cgi?id=2189866

Testing Instructions:

create pv-pool bucketstore.
take logs of the bucketstore
check that on trace "create_node_helper called with self.params: " access_key and secret_key are omitted

Doc added/updated
Tests added

nadavMiz requested review from a team and shirady and removed request for a team

May 21, 2023 06:49

pull-request-size bot added the size/XS label

nimrod-becker approved these changes

View reviewed changes

nadavMiz force-pushed the access-key-fix branch 2 times, most recently from 39bce07 to 93b7db3 Compare

May 21, 2023 08:15


          omit access key and secret in agent logs

9fa1f21

Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>

nadavMiz force-pushed the access-key-fix branch from 93b7db3 to 9fa1f21 Compare

May 21, 2023 09:36

nadavMiz merged commit 54b6c70 into noobaa:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment