Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_tags for copy from namespace-s3 #7303

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented May 21, 2023

Explain the changes

  1. Get tag_count from read_object_stream on s3 since this value is not always returned in read_object_md
  2. moved _populate_source_object_tagging to only run when copying on different servers. (when copying from the same server tagging is copied already)

Issues: Fixed #xxx / Gap #xxx

  1. Object Tagging Gaps on Namespace buckets #5341

Testing Instructions:

  1. create s3 namespace bucket, and noobaa bucket
  2. create object with tags on the s3 bucket
  3. copy object from s3 bucket to noobaa bucket with COPY tagging_dierctive
  4. run get_object_tagging on the new object. check that the tags were copied
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz requested review from a team and vh05 and removed request for a team May 21, 2023 08:28
@nadavMiz nadavMiz changed the title fix get_tags for copy from namespace-s3 Fix get_tags for copy from namespace-s3 May 21, 2023
@nadavMiz nadavMiz force-pushed the fix-s3-tagging branch 3 times, most recently from 53caf5b to b2ab385 Compare May 21, 2023 09:50
@nadavMiz nadavMiz requested review from romayalon and jackyalbo and removed request for romayalon May 23, 2023 10:02
@nadavMiz
Copy link
Contributor Author

added unit test for copying objects with tags within the same server and different servers. for the different server case I use AWS as a different server then noobaa, for namespace buckets I use noobaa bucket. didn't bother with azure, since azurite doesn't support tagging anyway

@nadavMiz nadavMiz requested a review from jackyalbo May 30, 2023 13:45
src/test/unit_tests/test_s3_ops.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_s3_ops.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_s3_ops.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_s3_ops.js Outdated Show resolved Hide resolved
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
@nadavMiz nadavMiz merged commit f8d94f4 into noobaa:master Jun 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants