-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_tags for copy from namespace-s3 #7303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
changed the title
fix get_tags for copy from namespace-s3
Fix get_tags for copy from namespace-s3
May 21, 2023
nadavMiz
force-pushed
the
fix-s3-tagging
branch
3 times, most recently
from
May 21, 2023 09:50
53caf5b
to
b2ab385
Compare
nadavMiz
requested review from
romayalon and
jackyalbo
and removed request for
romayalon
May 23, 2023 10:02
jackyalbo
reviewed
May 28, 2023
added unit test for copying objects with tags within the same server and different servers. for the different server case I use AWS as a different server then noobaa, for namespace buckets I use noobaa bucket. didn't bother with azure, since azurite doesn't support tagging anyway |
jackyalbo
reviewed
May 30, 2023
jackyalbo
approved these changes
Jun 1, 2023
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: