Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block recall from tier2 #7312

Merged

Conversation

tangledbytes
Copy link
Member

Explain the changes

This PR adds block recall feature from tier2 filesystem. It does not implement retries and rather would let the S3 client to retry the reads.

  • Doc added/updated
  • Tests added

@tangledbytes
Copy link
Member Author

Opened an issue identifying the gap in this PR.

Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

fix JSON parse error when xattr is absent

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

restructure to use filewrap methods - ensure fd is same throughout the operation

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

restructure

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
@tangledbytes tangledbytes force-pushed the utkarsh-pro/add/tier2-lazy-read branch from e1756b1 to 13e523c Compare June 1, 2023 07:30
@tangledbytes tangledbytes merged commit 60b30e1 into noobaa:master Jun 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants