Fix #7314: Use mtime instead of ctime when tier2 FS is enabled. #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
reviewed
Jun 5, 2023
guymguym
reviewed
Jun 5, 2023
guymguym
reviewed
Jun 5, 2023
There was a problem hiding this comment.
@Utkarsh-pro See comments, I don't have a concrete suggestion for renaming the use_mtime_check option, but I think it's a bit misleading as it is right now...
tangledbytes
force-pushed
the
utkarsh-pro/fix/7314
branch
2 times, most recently
from
f05863c
to
518db32
Compare
tangledbytes
force-pushed
the
utkarsh-pro/fix/7314
branch
from
518db32
to
a1da9ba
Compare
guymguym
reviewed
Jun 6, 2023
tangledbytes
force-pushed
the
utkarsh-pro/fix/7314
branch
from
a1da9ba
to
d25e03c
Compare
guymguym
reviewed
Jun 6, 2023
tangledbytes
force-pushed
the
utkarsh-pro/fix/7314
branch
3 times, most recently
from
a14e70d
to
b20ded9
Compare
tangledbytes
force-pushed
the
utkarsh-pro/fix/7314
branch
from
b20ded9
to
01d9d3f
Compare
cleanup
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
restructure
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
remove use_mtime_check flag
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
reformat ifs to conform to the style guide
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
fix errenous mtime call
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh-pro/fix/7314
branch
from
01d9d3f
to
2a0f07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds a simple flag in
fs_napiwhich forces usingmtimeinstead ofctimewherever appropriate. At some places use of mtime is not appropriate so in that place the check is completely skipped.Fixes: #7314