Bug Fix #7328 | Remove Duplications before Sending Them to Delete Multiple Objects

[shirady]

Explain the changes

1. Remove duplications before sending them to delete multiple objects.
2. Add parsing XML errors in case required parts the XML were not sent by the client.

Issues: Fixed #7328

1. Delete-objects reply of the same key objects should be the same as AWS.

2. If the client didn't send the XML with the Delete part we would have an error that we cannot read properties of undefined (tried to read 'Quiet'). Note: This was not part of the original issue but was reviled in the discussion of the PR.

Testing Instructions:

1. Are inside the issue mentioned above Delete Objects Reply of Same Key Objects Using Noobaa Endpoint Is Different than AWS #7328 .

• Doc added/updated
• Tests added

[jackyalbo]

Wouldn't it be better to remove duplicates from the request? before sending to the core? and then avoid it for the results?

[shirady]

Wouldn't it be better to remove duplicates from the request? before sending to the core? and then avoid it for the results?

Thank you, I changed it.
As far as I know, it would cause failed tests of src/test/unit_tests/test_bucketspace_versioning.js since there are tests that count the keys in the result.

[romayalon]

@shirady @jackyalbo

Wouldn't it be better to remove duplicates from the request? before sending to the core? and then avoid it for the results?

it's not just better but it's a must... the problem is not within the result array but within the request as Jacky mentioned,
I checked deleting multiple objects scenario against Amazon while bucket versioning is enabled, S3 will create only one delete marker, which means that AWS will not delete the object multiple times, so we shouldn't as well

[shirady]

@shirady @jackyalbo

Wouldn't it be better to remove duplicates from the request? before sending to the core? and then avoid it for the results?

it's not just better but it's a must... the problem is not within the result array but within the request as Jacky mentioned, I checked deleting multiple objects scenario against Amazon while bucket versioning is enabled, S3 will create only one delete marker, which means that AWS will not delete the object multiple times, so we shouldn't as well

@romayalon Thank you.
The current changes you see in this PR changes are after I took into account what @jackyalbo suggested.

• I will update the title in case it's confusing.